Support running commands while attached#379
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kevin-Li-2025 <2242139@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230.
Summary
Adds an optional command argument to
magic-trace attach, so users can attach to an existing process, run a workload, and have magic-trace detach automatically when that workload exits:magic-trace attach -p $PID -- ./load-generator arg1 arg2The existing Ctrl-C-driven attach flow is unchanged. The new path reuses the existing attach/record/decode pipeline, forwards the helper command's stdio, detaches when the helper exits, and still detaches promptly if magic-trace receives Ctrl-C first.
Validation
git diff --checkmakeattempted, but this local machine does not haveduneinstalled (make: dune: No such file or directory)