Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Ivar.fill with Ivar.fill_exn #314

Closed
wants to merge 1 commit into from

Conversation

erenon
Copy link

@erenon erenon commented Nov 20, 2024

On master, invoking make default results in:

File "src/trace.ml", line 481, characters 4-13:
481 |     Ivar.fill exited_ivar ();
          ^^^^^^^^^
Error (alert deprecated): Async.Ivar.fill
[since 2023-04] Use [fill_exn]

@Xyene
Copy link
Member

Xyene commented Nov 20, 2024

The build failed, most likely because your environment has dependencies that are newer than this repository expects.

Did you create a new switch for magic-trace? See https://github.com/janestreet/magic-trace/wiki/Build-instructions for details.

@erenon
Copy link
Author

erenon commented Nov 21, 2024

Thanks for the quick reply! For some reason, I couldn't find the build instruction wiki page... Followed the steps in a new shell, and it compiles now.

@erenon erenon closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants