Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce noise when OCaml exception tracking gets confused #301

Merged

Conversation

Xyene
Copy link
Member

@Xyene Xyene commented Jun 3, 2024

We're not going to be able to address all the corner cases any time soon, so in the meantime output exception tracking warnings at most once per trace.

We're not going to be able to address all the corner cases any time
soon, so in the meantime output exception tracking warnings at most once
per trace.

Signed-off-by: Tudor Brindus <[email protected]>
@Xyene Xyene requested a review from cgaebel June 3, 2024 21:22
Copy link
Contributor

@cgaebel cgaebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

@Xyene Xyene merged commit 5c45ca3 into janestreet:master Jun 3, 2024
1 check passed
@Xyene Xyene deleted the make-stairstepping-traces-less-noisy branch June 3, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants