Default iTerm color space is not AppleRGB #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbn
force-pushed
the
default_iterm_color_space_is_not_applergb
branch
from
4989969 to
245c27d
Compare
|
The "readability in all conditions." line is a selected line. Before
After
|
it's Generic RGB actually. And when exporting a color preset, it's saved with the sRBG color space usually. I've added the Alpha Component and Color Space keys to each color definition as it's exported by iTerm. See mbadolato/iTerm2-Color-Schemes#106 This fixes all the colors in iTerm. E.g the red color in the dark template was being rendered as #f6544f in sRGB, and now it's being correctly rendered as #fa5750. Also, I've updated the Selection Color to use bg_2 instead of bg_1, and the Cursor Color to use fg_1 instead of fg_0, same as in other templates, for better contrast.
ericbn
force-pushed
the
default_iterm_color_space_is_not_applergb
branch
from
245c27d to
804fdab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. 👋 First let me thank you for the amazing color palette you've created!
The default iTerm color space is Generic RGB actually. And when exporting a color preset, it's saved with the sRBG color space. I've added the Alpha Component and Color Space keys to each color definition as it's exported by iTerm.
See mbadolato/iTerm2-Color-Schemes#106
This fixes all the colors in iTerm. E.g the red color in the dark template was being rendered as #f6544f in sRGB, and now it's being correctly rendered as #fa5750.
Also, I've updated the Selection Color to use bg_2 instead of bg_1, and the Cursor Color to use fg_1 instead of fg_0, same as in other templates, for better contrast.