Skip to content

Commit

Permalink
adopt to scipy v1.12
Browse files Browse the repository at this point in the history
* scipy.stats.binom_test was removed from scipy v1.12
see https://docs.scipy.org/doc/scipy-1.11.4/reference/generated/scipy.stats.binom_test.html

* specify minimal version for development (testing) of scipy as 1.7
  • Loading branch information
jan-glx authored Mar 22, 2024
1 parent e03d895 commit c74bdad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ urls = {source = 'https://github.com/jan-glx/ICPy'}
dependencies = ['numpy', 'scipy', 'scikit-learn',]

[project.optional-dependencies]
test = ['pytest', 'pytest-cov', 'coverage',]
test = ['pytest', 'pytest-cov', 'coverage', 'scipy>=1.7.0']
doc = ['sphinx', 'furo', 'myst_parser']


Expand Down
2 changes: 1 addition & 1 deletion tests/test_ICP.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def one():

N = 100
K = sum((one() for _ in range(N)))
p_value = scipy.stats.binom_test(K, N, alpha, alternative="greater")
p_value = scipy.stats.binomtest(K, N, alpha, alternative="greater").pvalue
self.assertGreater(p_value, 0.01)

def test_parent_set_generator(self):
Expand Down

0 comments on commit c74bdad

Please sign in to comment.