small refactor to clarify logic #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 586e6a9 in 7 seconds
More details
- Looked at
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js-pkg/client/src/provider.ts:311
- Draft comment:
The refactor correctly simplifies the logic by removing redundant checks forauthEndpointtype. This relies ongetClientTokento handle both cases, which is a cleaner approach. - Reason this comment was not posted:
Confidence changes required:0%
The refactor simplifies the logic by removing redundant checks and relying on thegetClientTokenfunction to handle both cases ofauthEndpoint. This is a good change as it reduces code duplication and potential errors.
Workflow ID: wflow_iEDknlw7PJ0erQqH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
michaelsilver
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small logic clarification I came across as I was catching up on the new provider.
getClientTokenalready handles theAuthEndpointtype for both cases: when it's afunctionand when it's astring.