Outline Y-Sweet logo #346
Merged
Outline Y-Sweet logo #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgb
requested review from
jakelazaroff,
rolyatmax,
michaelsilver and
feliciachang
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e4126e3 in 1 minute and 10 seconds
More details
- Looked at
641lines of code in11files - Skipped
1files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. crates/y-sweet/src/main.rs:181
- Draft comment:
The PR description mentions changes related to the Y-Sweet logo, but the code changes are related to setting up Python tests and modifying server code. Please ensure the PR description matches the changes made. - Reason this comment was not posted:
Comment did not seem useful.
2. crates/y-sweet/src/server.rs:360
- Draft comment:
The PR description mentions changes related to the Y-Sweet logo, but the code changes are related to setting up Python tests and modifying server code. Please ensure the PR description matches the changes made. - Reason this comment was not posted:
Marked as duplicate.
3. crates/y-sweet/src/server.rs:382
- Draft comment:
Usingunwrapin async functions can lead to panics if the result is an error. Consider handling the error gracefully instead of usingunwrap. This is also applicable in other parts of the code whereunwrapis used in async contexts. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_gX4BtbeJYjA8xAd7
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
paulgb
force-pushed
the
paulgb/outline-logo
branch
from
e4126e3 to
9237278
Compare
There was a problem hiding this comment.
Skipped PR review on 9237278 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
Merged
jakelazaroff
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Y-Sweet logo has a white outline as part of the logo with some gradients that add depth. On white, the outline is completely invisible except for the gradients, which look like flaws. This adds an outline to the logo so that the outline is apparent on a light background. The outline matches the default GitHub "dark mode" color, so it is completely invisible on the default dark mode.
Before:
After: