Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input sanitization #4

Open
kieranrcampbell opened this issue Mar 8, 2019 · 1 comment
Open

Input sanitization #4

kieranrcampbell opened this issue Mar 8, 2019 · 1 comment

Comments

@kieranrcampbell
Copy link
Collaborator

In the main function you'll need to

  1. Check that the input is a SingleCellExperiment - could also reasonably be a count matrix?

  2. Be nicer about user clusters. Currently has
    clusters <- lapply(clusters, as.vector, "numeric")
    but what if this is instead a character vector of cluster names? What happens if some cells aren't assigned clusters (ie there are NA values)

  3. The clusters currently have to be "A list of clusters, an array or list of integers of same length as number of cells in sce." - what's the difference between a "list of clusters" and a "list of integers"? Also it starts with lapply (see above) - with this work with an array?

@kieranrcampbell
Copy link
Collaborator Author

Similarly, you'll want to check the dimensionality of the clusters matches the input SCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant