Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jamesramsay
I've implemented the (hopefully) smart header indentation from issue #387
I've made the call that if the transcluded content is indented and contains a header, then the header is not incremented.
I've also made a small API change which I can remove if you want, which is to pass the entire chunk to resolvers. This would open the door to implementing header incrementation in resolvers, or generally give access to the context of the transclusion.
I ran the benchmarks and it seems that the performance overhead is small:
master branch
headers branch
Let me know what you think!
Cheers,
Jun