Reduce Electron app size (microsoft#770)

* Don’t include node_modules in Electron build Signed-off-by: Mick Vleeshouwer <[email protected]> * Update electron from 8 to 10 Signed-off-by: Mick Vleeshouwer <[email protected]> Co-authored-by: stew-ro <[email protected]>
jamesor19 · Nov 16, 2020 · 4fcd7ff · 4fcd7ff
1 parent e19d372
commit 4fcd7ff
Show file tree

Hide file tree

Showing 4 changed files with 141 additions and 124 deletions.
diff --git a/electron-builder.yml b/electron-builder.yml
@@ -9,6 +9,7 @@ extends: null # need this otherwise it won't use the entry point we set in "main
 files:
   - filter:
       - build/  # copy this directory to the asar directory that electron-builder use to look for the main entry file
+      - "!node_modules/**/*" # don't include node_modules since Webpack is used to combine all packages
 mac:
   icon: app-icons/icon.icns
   target: dmg

diff --git a/package.json b/package.json
@@ -99,8 +99,8 @@
         "@types/reactstrap": "^8.2.0",
         "@types/redux-logger": "^3.0.7",
         "acorn": "^7.1.1",
-        "electron": "8.3.0",
-        "electron-builder": "^22.6.1",
+        "electron": "10.1.5",
+        "electron-builder": "^22.9.1",
         "env-cmd": "^10.1.0",
         "enzyme": "^3.10.0",
         "enzyme-adapter-react-16": "^1.15.1",

diff --git a/src/electron/main.ts b/src/electron/main.ts
@@ -31,6 +31,7 @@ async function createWindow() {
     windowOptions.webPreferences = {
         nodeIntegration: true,
         webSecurity: false,
+        enableRemoteModule: true
     };
 
     const staticUrl = process.env.ELECTRON_START_URL || `file:///${__dirname}/index.html`;