Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use document title as root node (optionally) #77

Merged
merged 3 commits into from
Jan 23, 2023
Merged

feat: use document title as root node (optionally) #77

merged 3 commits into from
Jan 23, 2023

Conversation

james-tindal
Copy link
Owner

Implements #60.

With one top-level heading:

With multiple top-level headings:

MasterTuto
MasterTuto suggested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@MasterTuto MasterTuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for leaving your PR, I'd be glad if you made the changes I have requests.

Thanks for your contribution.

src/mindmap-view.ts Outdated Show resolved Hide resolved
@AdrianSimionov
Copy link
Contributor

Can we please add documentation and a front-matter option on top of the plugin settings? The front-matter option will take precedence and be applied only to the current .md file.

@james-tindal
Copy link
Owner Author

I'll work on the front matter issues tomorrow morning and write it up in the readme

@AdrianSimionov AdrianSimionov linked an issue Jan 10, 2023 that may be closed by this pull request
Use document title as root node #60
Closed
@james-tindal
Copy link
Owner Author

@AdrianSimionov I followed the image, resolved the conflicts, merged and committed, but I don't have permission to push from the CLI.

@james-tindal
Copy link
Owner Author

I can merge it differently though so that shouldn't be a problem.

@james-tindal
Copy link
Owner Author

I noticed the map doesn't update when the setting changes. PR #86 (multiple tabs) sets up some stuff that I will base this functionality on, so I'm waiting on that.

@james-tindal
refactor: simplify filesystem-data.ts
d26725c
@james-tindal
feat: Document title as root node
2e87e53
@james-tindal
docs: multiple...
d8a729d 
* Rephrase frontmatter description

* Add description of title as root node functionality

* Explain coloring approaches
@james-tindal james-tindal merged commit b181e2d into james-tindal:main Jan 23, 2023
@james-tindal james-tindal deleted the title-as-root-node branch January 24, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterTuto MasterTuto MasterTuto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use document title as root node
3 participants
@james-tindal @AdrianSimionov @MasterTuto