[L33T-3002] Update #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with jibri that are served on different virtual host and jiconop2 does not work for them.
…ated codec. If Jicofo doesn't offer VP9 but the client expresses a preference for VP9, VP9 bitrates were being imposed before.
This fixes an issue where the bridge doesn't forward the HD stream from Firefox to other users in the call. The order of the ssrcs produced by the browser is from Highest resolution to lowest whereas the bridge assumes it to be from lowest to highest as is the case in Chrome and Safari.
For some reason webpack seems to not be transpiling that properly. Fixes: jitsi#1722
Credit to Stephen Donner.
…itsi#1729) * feat(av-moderation) Remove from moderation whitelist functionality * Fix comment
Log only the important events that we care about on the HTMLMediaElement that the remote tracks are attached to.
It makes more sense to call it pcConfig since it is the RTCConfiguration object passed to the WebRTC peerconnection.
Instead of logging the full IQs for Jingle messages like session-initiate, source-add and source-remove which can be very long, log just the formatted source information.
ChatRoom.setAudioMute and ChatRoom.setVideoMute are not async, so no callbacks nor promises are necessary.
If a second JitsiConference instance for the same room is created we were throwing an error but some listeners were already attached. This commit makes sure that we throw the error as soon as possible and no listeners are added.
There was an error in the pattern match, everything was included in it. In addition return a boolean in case we succeed in the UA pattern match, since it's more correct than returning an array with the match.
Maybe due to our DOM wrappers, the Symbol.iterator is not implemented, so iterate over the IQ fields old-school style.
This is the first step in adding support for multiple streams per endpoint. Each source(stream?) needs to have an identifier. For now always generate the 0 index name until the machinery for sending more than 1 stream is put in place. * send only MSID attribute * add feature flag for source name signaling * log a msg if source name signaling is enabled
… set We need to make sure the audio track is added to the JVB connection, or we won't be able to unmute. Why this happens is a mystery wrapped in an enigma, it started happening with iOS 15. Same thing applies to Safari for macOS. Fixes: jitsi/jitsi-meet#10104
We are not actually using it here.
Improve compatibility with Webpack 5.
Increase the RTC mute timeout from 500ms to 2500ms for p2p connections. This fixes an issue with Chrome tab sharing where the application keeps switching between the avatar and the share contnuously because of a chrome bug https://bugs.chromium.org/p/chromium/issues/detail?id=1258034
* feat(CodecSelection) Disable VP9 on Safari. Safari does not decode VP9 properly- https://bugs.webkit.org/show_bug.cgi?id=231071 and https://bugs.webkit.org/show_bug.cgi?id=231074. * squash move VP9 support check to browser capabilities.
* ref(TPC) Configure encodings in one go. Configure the active state, maxBitrate and degradation preference in one go instead of configuring them separately. * squash: Address review comments. * squash: fix a comment.
We do not want Firefox sending video when its video muted. https://bugzilla.mozilla.org/show_bug.cgi?id=1735951
…si#1754) * feat: Adds to JitsiConferenceEvents CONFERENCE_JOIN_IN_PROGRESS. * squash: Fixes tests.
Instead rely on the 'negotiationneeded' event fired by the browser for JVB connection. This makes local source changes faster even if the modification queue is backed up.
The issue was caused by incorrect ordering of the mixedmslabel mline. sdp-interop is expecting that this mline was the first one but in reality we were placing it last. This was causing the direction of a user related m line to be sendrecv instead of sendonly. In certain situation this issue was causing 2 MediaStreamTracks associated with a single MediaStream/participant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.