Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements: fix failing test #112

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SumanthRH
Copy link

Hi @jalammar , looks like I missed a commit on #110. All updates are on 68d8931 . Changes since last time:

  • change import of top_k_top_p_filtering
  • Use raw string in regex search to get rid of DeprecationWarning:
DeprecationWarning: invalid escape sequence '\.'
    layer_number = re.search("(?<=\.)\d+(?=\.)", name).group(0)

I've run pytest tests locally (python 3.10) and all tests pass. This should work now!

@SumanthRH SumanthRH changed the title Update transformers: fix failing test Update requirements: fix failing test Jan 24, 2024
@SumanthRH
Copy link
Author

Ping @jalammar. I've also added a small test for bfloat16 and it works!

Also, I believe the pre-commit hooks need to be updated (had some issues), so I will add that in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant