Skip to content

Conversation

@jbescos
Copy link
Member

@jbescos jbescos commented Oct 1, 2025

#812

This could be handy for this review. It contains the changes when only jakarta files were going to be loaded.

Draft for now. I need to check more things.

@jbescos jbescos marked this pull request as draft October 1, 2025 16:06
@jbescos jbescos force-pushed the issue812 branch 2 times, most recently from cf42970 to c71b0db Compare October 2, 2025 05:37
@jbescos jbescos marked this pull request as ready for review October 2, 2025 05:38
public synchronized void addProvider(Provider provider) {
providers.add(provider);
providersByClassName.put(provider.getClassName(), provider);
if (!providersByClassName.containsKey(provider.getClassName()))
Copy link
Member Author

@jbescos jbescos Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this part a bit confusing. We now need this to prevent Jakarta resource overwriting JavaMail. But if we were already performing this check in providersByProtocol, why wasn’t it added here earlier?

@jbescos jbescos marked this pull request as draft October 3, 2025 05:25
@jbescos jbescos marked this pull request as ready for review October 3, 2025 08:38
…are no longer loaded with Jakarta Mail 2.1.5 jakartaee#812

Signed-off-by: Jorge Bescos Gascon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant