Issue #734: Fix possible concurrent modification problem #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Chan <[email protected]>
jmehrens
reviewed
Sep 5, 2024
Signed-off-by: Arthur Chan <[email protected]>
jmehrens
requested changes
Oct 10, 2024
Contributor
jmehrens
left a comment
jmehrens
left a comment
There was a problem hiding this comment.
You'll have to:
- Sign the ECA.
- Add your test cases from the ticket as JUnit test
| // Details in Issue#734 | ||
| throw new ParseException("Invalid parameter list string."); | ||
| // should never happen | ||
| it.remove(name); |
Contributor
There was a problem hiding this comment.
Iterator remove doesn't take are arguments
it.remove()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a fix for #734.