tests for issue #687 #688
Open
tests for issue #687 #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasj
reviewed
Jan 6, 2024
| @Test | ||
| public void testQEncoding() throws Exception { | ||
| String disposition = ";\n" + | ||
| " filename==?utf-8?Q?XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX--111111111-XXXXXXXXXXXXXXXXXXX?=\n" + |
There was a problem hiding this comment.
filename==?utf-8?Q?X... is invalid - it is missing *, it should be filename*==?utf-8?Q?X..., so the failure here is actually correct behaviour
lukasj
reviewed
Jan 6, 2024
| " filename==?utf-8?Q?XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX--111111111-XXXXXXXXXXXXXXXXXXX?=\n" + | ||
| " =?utf-8?Q?XXXXXXXXXXXXXXXXXXX=2Epdf?=;\n" + | ||
| " filename*0*=utf-8''XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX--111111111-XXXXXXXXXXX;\n" + | ||
| " filename*1*=XXXXXXXXXXXXXXXXXXXXXXXXXXX.pdf"; |
There was a problem hiding this comment.
this could probably be handled in a way that if there is a valid variant of the parameter then ignore (and just log) the invalid one in non-string operation mode or through some new, different property.
An implementation of this would probably need adding a property to ParameterList to keep track of decoded parameters and tweak the behaviour of combineMultisegmentNames method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the issue #687