Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[badger] Untangle cache logic from db access logic #6575

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

Manik2708
Copy link
Contributor

@Manik2708 Manik2708 commented Jan 20, 2025

Which problem is this PR solving?

Comment: #6376 (comment)

Description of the changes

  • Cache was directly contacting the db to prefill itself which is not a good way, now this responsibility is given to reader to read from badger and fill the cache.

How was this change tested?

  • Unit and e2e tests

Checklist

@Manik2708 Manik2708 requested a review from a team as a code owner January 20, 2025 19:08
@dosubot dosubot bot added the storage/badger Issues related to badger storage label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (156a59d) to head (07b7cc3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
+ Coverage   96.21%   96.24%   +0.02%     
==========================================
  Files         375      375              
  Lines       21389    21397       +8     
==========================================
+ Hits        20580    20593      +13     
+ Misses        616      612       -4     
+ Partials      193      192       -1     
Flag Coverage Δ
badger_v1 10.60% <31.74%> (-0.06%) ⬇️
badger_v2 2.78% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 16.60% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 16.60% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2-auto 2.71% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 2.71% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 20.38% <0.00%> (-0.02%) ⬇️
elasticsearch-7.x-v1 20.46% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 20.61% <0.00%> (-0.03%) ⬇️
elasticsearch-8.x-v2 2.78% <0.00%> (+<0.01%) ⬆️
grpc_v1 12.17% <0.00%> (-0.01%) ⬇️
grpc_v2 9.02% <0.00%> (-0.01%) ⬇️
kafka-3.x-v1 10.33% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 2.78% <0.00%> (-0.01%) ⬇️
memory_v2 2.77% <0.00%> (-0.02%) ⬇️
opensearch-1.x-v1 20.50% <0.00%> (-0.03%) ⬇️
opensearch-2.x-v1 20.51% <0.00%> (-0.02%) ⬇️
opensearch-2.x-v2 2.78% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.51% <0.00%> (-0.01%) ⬇️
unittests 95.09% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Manik2708 <[email protected]>
@yurishkuro
Copy link
Member

please provide better description of the changes in the PR description.

@Manik2708 Manik2708 requested a review from yurishkuro January 21, 2025 06:07
Signed-off-by: Manik2708 <[email protected]>
@Manik2708 Manik2708 requested a review from yurishkuro January 21, 2025 16:43
@Manik2708
Copy link
Contributor Author

@yurishkuro Do store need to be a part of cache anymore?

@yurishkuro yurishkuro changed the title [refactor][storage][badger]Refactored the prefilling of cache to reader [badger] Untangle cache logic from db access logic Jan 21, 2025
@yurishkuro yurishkuro merged commit caccdce into jaegertracing:main Jan 21, 2025
55 checks passed
@Manik2708 Manik2708 deleted the badger-refactor branch February 6, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants