-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[badger] Untangle cache logic from db access logic #6575
Conversation
Signed-off-by: Manik2708 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6575 +/- ##
==========================================
+ Coverage 96.21% 96.24% +0.02%
==========================================
Files 375 375
Lines 21389 21397 +8
==========================================
+ Hits 20580 20593 +13
+ Misses 616 612 -4
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manik2708 <[email protected]>
please provide better description of the changes in the PR description. |
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
Signed-off-by: Manik2708 <[email protected]>
@yurishkuro Do store need to be a part of cache anymore? |
Which problem is this PR solving?
Comment: #6376 (comment)
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test