-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix call to GetDependencies
in grpc handler
#6324
[fix] Fix call to GetDependencies
in grpc handler
#6324
Conversation
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
feels like we're missing adequate unit tests that could've caught this. |
@yurishkuro The call is mocked and the wrong expectations were set on the mocks. Did you have something else in mind? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6324 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 356 356
Lines 20476 20476
=======================================
Hits 19681 19681
Misses 607 607
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description of the changes
startTime
toGetDependencies
instead ofendTime
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test