Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix call to GetDependencies in grpc handler #6324

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Description of the changes

  • This PR fixes a bug in the query GRPC handler which currently passes startTime to GetDependencies instead of endTime

How was this change tested?

  • Fixed unit test expectations

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 7, 2024 21:09
@yurishkuro
Copy link
Member

feels like we're missing adequate unit tests that could've caught this.

@mahadzaryab1 mahadzaryab1 enabled auto-merge (squash) December 7, 2024 21:13
@mahadzaryab1
Copy link
Collaborator Author

feels like we're missing adequate unit tests that could've caught this.

@yurishkuro The call is mocked and the wrong expectations were set on the mocks. Did you have something else in mind?

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (593315b) to head (7d5f7f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6324   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         356      356           
  Lines       20476    20476           
=======================================
  Hits        19681    19681           
  Misses        607      607           
  Partials      188      188           
Flag Coverage Δ
badger_v1 8.83% <ø> (ø)
badger_v2 1.62% <ø> (ø)
cassandra-4.x-v1-manual 14.73% <ø> (ø)
cassandra-4.x-v2-auto 1.56% <ø> (ø)
cassandra-4.x-v2-manual 1.56% <ø> (ø)
cassandra-5.x-v1-manual 14.73% <ø> (ø)
cassandra-5.x-v2-auto 1.56% <ø> (ø)
cassandra-5.x-v2-manual 1.56% <ø> (ø)
elasticsearch-6.x-v1 18.47% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.54% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.70% <ø> (ø)
elasticsearch-8.x-v2 1.61% <ø> (ø)
grpc_v1 10.28% <ø> (-0.01%) ⬇️
grpc_v2 7.85% <ø> (ø)
kafka-v1 8.52% <ø> (ø)
kafka-v2 1.62% <ø> (ø)
memory_v2 1.62% <ø> (ø)
opensearch-1.x-v1 18.60% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.60% <ø> (ø)
opensearch-2.x-v2 1.62% <ø> (ø)
tailsampling-processor 0.45% <ø> (ø)
unittests 95.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 merged commit 723202b into jaegertracing:main Dec 7, 2024
55 of 56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the fix-dep-reader-args branch December 7, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants