Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Use only version number for BuildInfo #6260

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 26, 2024

Which problem is this PR solving?

We were passing the whole VersionInfo to OTEL's BuildInfo, which resulted in the metrics being labeled with a very long string: service_version="git-commit=600d82c5815289ba13197ce80b742c0f4411df78, git-version=v2.0.0, build-date=2024-11-26T15:15:15Z"

Description of the changes

Only pass the actual version. The metrics become much more readable: jaeger_query_responses_count{operation="get_services",service_instance_id="06f22e3e-3ad7-4067-8b0f-15d35b329712",service_name="jaeger",service_version="v2.0.0"}

How was this change tested?

$ curl -s http://localhost:8888/metrics | grep -v '^#' | grep 'get_services'

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from a team as a code owner November 26, 2024 16:16
@yurishkuro yurishkuro changed the title Use only version number [v2] Use only version number for BuildInfo Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (600d82c) to head (e5541f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6260      +/-   ##
==========================================
+ Coverage   96.44%   96.45%   +0.01%     
==========================================
  Files         355      355              
  Lines       20155    20155              
==========================================
+ Hits        19438    19441       +3     
+ Misses        528      526       -2     
+ Partials      189      188       -1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (ø)
opensearch-2.x-v2 ?
tailsampling-processor 0.46% <ø> (ø)
unittests 95.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 2a07dfb into jaegertracing:main Nov 26, 2024
52 of 53 checks passed
@yurishkuro yurishkuro deleted the actual-version branch November 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants