Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move SPM v2 config to cmd/jaeger/ with all other configs #6256

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 26, 2024

Which problem is this PR solving?

  • This config was demonstrating a setup with span metrics processor, but was stashed in example directory

Description of the changes

  • Move the config to /cmd/jaeger/ where all other v2 configs are

How was this change tested?

  • ran SPM locally
  • CI

Follow-ups

  • check if SPM documentation points to the old location of the config

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (d6ca388) to head (da5ed5d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6256      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.02%     
==========================================
  Files         355      355              
  Lines       20150    20150              
==========================================
- Hits        19438    19435       -3     
- Misses        525      527       +2     
- Partials      187      188       +1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.85% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v2 1.66% <ø> (-0.01%) ⬇️
grpc_v1 9.44% <ø> (ø)
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member Author

@mahadzaryab1 please review

@yurishkuro yurishkuro changed the title Move SPM v2 config to cmd/jaeger/ with all other configs [refactor] Move SPM v2 config to cmd/jaeger/ with all other configs Nov 26, 2024
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 600d82c into jaegertracing:main Nov 26, 2024
52 checks passed
@yurishkuro yurishkuro deleted the move-spm-config branch November 26, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants