Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade antd and @ant-design/compatible to latest version #2645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hari45678
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • This PR upgrades the antd and @ant-design/compatible to latest version which wold unblock the jsdom PR by renovate bot since ant-design have introduced some changes to the selectors internally in the rc-* packages.

How was this change tested?

  • npm run test
  • ui changes using npm run start

Checklist

@hari45678 hari45678 requested a review from a team as a code owner February 4, 2025 04:21
@hari45678 hari45678 requested review from jkowall and removed request for a team February 4, 2025 04:21
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (87bea11) to head (eb2aa36).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         255      255           
  Lines        7726     7726           
  Branches     2013     1939   -74     
=======================================
  Hits         7465     7465           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hari45678
Copy link
Contributor Author

hari45678 commented Feb 4, 2025

@yurishkuro This PR should unblock the jsdom PR by renovate bot.

The prior attempt in PR #2579 failed because upgrading antd upgraded some of its peer deps which others were still waiting for an upgrade because ant-design/compatible wasn't upgraded. Renovate bot is a lot buggy as it shouldn't have upgraded the lockfile explicitly without upgrading ant-design/compatible in package.json

@hari45678 hari45678 changed the title [deps]: upgrade antd and @ant-design/compatible to latest version Upgrade antd and @ant-design/compatible to latest version Feb 4, 2025
@hari45678 hari45678 mentioned this pull request Feb 4, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant