Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultProps from ErrorMessage & NewWindowIcon #2609

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

ADI-ROXX
Copy link
Contributor

@ADI-ROXX ADI-ROXX commented Jan 23, 2025

Which problem is this PR solving?

Description of the changes

  • Wherever the default value was undefined, I have not added a default value for it since it is automatically undefined.

How was this change tested?

  • npm run lint test

Checklist

@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 23, 2025 19:22
@ADI-ROXX ADI-ROXX requested review from mahadzaryab1 and removed request for a team January 23, 2025 19:22
Signed-off-by: cs-308-2023 <[email protected]>
@ADI-ROXX
Copy link
Contributor Author

@yurishkuro Can you review it once?

@ADI-ROXX
Copy link
Contributor Author

@yurishkuro Shall I wait for this pr to be merged before I start removing the defaultProps of another file? Or shall I add another PR immediately?

Because I have made the changes required for the next file on my local machine.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (2159753) to head (bbe97b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
- Coverage   96.61%   96.61%   -0.01%     
==========================================
  Files         255      255              
  Lines        7745     7738       -7     
  Branches     1937     2004      +67     
==========================================
- Hits         7483     7476       -7     
  Misses        262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 23, 2025
@yurishkuro yurishkuro changed the title Remove defaultProps from ErrorMessage.tsx Remove defaultProps from ErrorMessage & NewWindowIcon Jan 23, 2025
@yurishkuro yurishkuro enabled auto-merge (squash) January 23, 2025 21:38
@yurishkuro yurishkuro merged commit 2d880b4 into jaegertracing:main Jan 23, 2025
9 of 10 checks passed
@yurishkuro
Copy link
Member

Please do not put Resolves #xxx in the description if the PR is only for part of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Support for defaultProps in Function Components to be Removed
2 participants