-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update redux and react-redux to latest version #2537
Conversation
Signed-off-by: Hariom Gupta <[email protected]>
I can see PR #2535 is also trying to solve the linked issue, though it wasn't updated (was failing on tests and lint) at the time I created this PR, so I can close this PR if necessary. Would look out other issues. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 255 255
Lines 7728 7728
Branches 2002 1950 -52
=======================================
Hits 7468 7468
Misses 260 260 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hariom Gupta <[email protected]>
Thanks! |
…rtracing#2537)" This reverts commit 82f827e.
…rtracing#2537)" This reverts commit 82f827e. Signed-off-by: Hariom Gupta <[email protected]>
Reverts #2537 Reason: #2542 (comment) Part of #2530 --------- Signed-off-by: Hariom Gupta <[email protected]>
Which problem is this PR solving?
Description of the changes
string
. According to them, this change is to make the action obj serializable. Change log: https://redux.js.org/usage/migrations/migrating-rtk-2#action-types-must-be-stringsrequireActual
injest.mock
, it would anyway be the actual implementation of functions for other test cases.How was this change tested?
npm run start
is working fine with Trace Diff pageChecklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test