Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update redux and react-redux to latest version #2537

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

hari45678
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • With redux 5, type of an action is now a string. According to them, this change is to make the action obj serializable. Change log: https://redux.js.org/usage/migrations/migrating-rtk-2#action-types-must-be-strings
  • In the test, due to some import error, redux no longer has configurable properties, and jest requires them to be configurable for spying and changing their behavior. More context on this.
  • Since we are using requireActual in jest.mock, it would anyway be the actual implementation of functions for other test cases.

How was this change tested?

  • npm run start is working fine with Trace Diff page

Checklist

Signed-off-by: Hariom Gupta <[email protected]>
@hari45678 hari45678 requested a review from a team as a code owner January 4, 2025 05:51
@hari45678 hari45678 requested review from jkowall and removed request for a team January 4, 2025 05:51
@hari45678
Copy link
Contributor Author

I can see PR #2535 is also trying to solve the linked issue, though it wasn't updated (was failing on tests and lint) at the time I created this PR, so I can close this PR if necessary. Would look out other issues.

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (9feb3bd) to head (526d360).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2537   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7728           
  Branches     2002     1950   -52     
=======================================
  Hits         7468     7468           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

I like this PR better than #2535 because it's smaller and still passes the CI. Why are the other changes in #2535 ?

@hari45678
Copy link
Contributor Author

I like this PR better than #2535 because it's smaller and still passes the CI. Why are the other changes in #2535 ?

I couldn't find a reason to modify the already written tests for such a change

@yurishkuro yurishkuro changed the title chore: update redux and react-redux to latest version [chore] Update redux and react-redux to latest version Jan 4, 2025
@yurishkuro yurishkuro merged commit 82f827e into jaegertracing:main Jan 4, 2025
8 checks passed
@yurishkuro
Copy link
Member

Thanks!

@yurishkuro yurishkuro mentioned this pull request Jan 4, 2025
4 tasks
hari45678 added a commit to hari45678/jaeger-ui that referenced this pull request Jan 5, 2025
hari45678 added a commit to hari45678/jaeger-ui that referenced this pull request Jan 5, 2025
yurishkuro pushed a commit that referenced this pull request Jan 5, 2025
@hari45678 hari45678 deleted the up-rdx branch January 7, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deps]: Upgrade react-redux to 9.x
2 participants