Update the tooltip arrow convention. fixes #2221 #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Signed-off-by: bupd <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 254 254
Lines 7641 7641
Branches 1927 1927
=======================================
Hits 7381 7381
Misses 260 260 ☔ View full report in Codecov by Sentry. |
|
please include before / after screenshots |
tanvincible
reviewed
Jan 26, 2025
| @@ -63,7 +63,7 @@ export default class MetricCard extends React.PureComponent<TProps> { | |||
| <div className="MetricCard--Body"> | |||
| <span className="MetricCard--TitleHeader"> | |||
| {name}{' '} | |||
| <Tooltip arrowPointAtCenter title="Metric Documentation"> | |||
| <Tooltip arrow={{ pointAtCenter: true }} title="Metric Documentation"> | |||
There was a problem hiding this comment.
This change has been addressed in #2602.
There was a problem hiding this comment.
@tanvincible there were more changes in this PR than in #2602, can you reproduce them all?
There was a problem hiding this comment.
@yurishkuro, this one seems abandoned. Can I go ahead and work on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test