Use SSL context for wrapping socket #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fine-grained control over the SSL/TLS-settings. It includes the following changes:
_tcp_socket_check()
handles those exceptions now as well.wrap_socket()
function is deprecated. Instead, a context with secure default settings is created.use_secure
(instead of the default context whenuse_secure=True
).Alternative to 3.: Instead of the option to pass a SSL context directly to
use_secure
, a new optional keyword-argument could be used as well.This implementation is working on my side, but I still left "untested" in the docstring until someone else can confirm.