Add classification and additional non-compositional covariates #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of https://github.com/viettr/trac # Conflicts: # .Rbuildignore # .gitignore # DESCRIPTION # R/cv_trac.R # R/predict.R # R/trac.R # man/cv_trac.Rd # man/trac.Rd # tests/testthat.R # tests/testthat/test-trac.R
Merge remote-tracking branch 'upstream/master' # Conflicts: # R/log_contrast.R # R/trac.R
…ovariates to log-contrast
jacobbien
reviewed
Jun 20, 2022
Comment on lines
+33
to
+34
| if (is.null(fit$w_additional_covariates)) { | ||
| fit$w_additional_covariates <- NULL |
Author
There was a problem hiding this comment.
Thats a good point! I tried to make it backwards compatible but this line is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jacob,
this pull request extends trac in two ways. First it allows for classification and second the user can add additional non-compositional covariates. Another extension is the implementation of the two-stage procedure proposed in https://onlinelibrary.wiley.com/doi/abs/10.1111/biom.12995. The pull request also provides more vignettes and tests.
There are major changes in the following files: