Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Improving Spanish & adding Catalan and British English #1240

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

IL01DI
Copy link
Contributor

@IL01DI IL01DI commented Jun 28, 2024

Hello! 👋

I would like to make changes to the Spanish translation, replacing the infinitive form to conjugated present (of indicative) form, since it is more natural. Furthermore, some past tense verbs have also been replaced by their usage in Spain (not in America).

As for British English, I don't see any difference, but I would recommend adding it. Also, I provided a Catalan translation.

Thanks in advance,
L01D

@tremulotmaths
Copy link

Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #1240

#1240

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@Simber1
Copy link
Contributor

Simber1 commented Jun 29, 2024

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

@IL01DI
Copy link
Contributor Author

IL01DI commented Jun 29, 2024

Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #1240

#1240

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

@tremulotmaths, why you suggested this kind of code in my PR? It doesn't involve on the topic at all.

@IL01DI
Copy link
Contributor Author

IL01DI commented Jun 29, 2024

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

What do you mean specifically when you “changed it to en_GB”? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.

UPDATE: I tested it, and it works for me without any error.

@Simber1
Copy link
Contributor

Simber1 commented Jun 29, 2024

+1 on the British English, when setting quartz up the other day I instinctively changed it to en-GB before my IDE yelled at me telling me it wasn't valid.

What do you mean specifically when you “changed it to en_GB”? I haven't tried yet, but the fact that isn't valid made me think that it might be the lack of support towards one language with multiple regions. Although qwartz theoretically supports it, I can't see any language with more regions added.

The other day (not using this branch) when I set up quartz I set the locale to en-GB and got a type error as the locale field is the type ValidLocale which only accepts locales in the TRANSLATIONS var in i18n/index.ts. Since you have added it to there it will be fine from a type hinting prospective.

@jackyzha0 jackyzha0 changed the title Improving Spanish & adding Catalan and British English i18n: Improving Spanish & adding Catalan and British English Jul 1, 2024
@jackyzha0 jackyzha0 merged commit dbe12c0 into jackyzha0:v4 Jul 1, 2024
4 checks passed
wingadium1 pushed a commit to wingadium1/athena that referenced this pull request Aug 12, 2024
…a0#1240)

* Create en-GB

* Rename en-GB to en-GB.ts

* Update es-ES.ts

* Update es-ES.ts

* Create ca-ES.ts

* Update es-ES.ts

* Update index.ts

* Update index.ts

* Update index.ts

* Update es-ES.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants