-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Improving Spanish & adding Catalan and British English #1240
Conversation
Hey @IL01DI, while reviewing your PR, I'd suggest the following code changes: You can also review and apply these suggestions locally on your machine. Learn more about GitKraken Code Suggest
Join your team on GitKraken to speed up PR review. |
+1 on the British English, when setting quartz up the other day I instinctively changed it to |
@tremulotmaths, why you suggested this kind of code in my PR? It doesn't involve on the topic at all. |
What do you mean specifically when you “changed it to UPDATE: I tested it, and it works for me without any error. |
The other day (not using this branch) when I set up quartz I set the locale to |
…a0#1240) * Create en-GB * Rename en-GB to en-GB.ts * Update es-ES.ts * Update es-ES.ts * Create ca-ES.ts * Update es-ES.ts * Update index.ts * Update index.ts * Update index.ts * Update es-ES.ts
Hello! 👋
I would like to make changes to the Spanish translation, replacing the infinitive form to conjugated present (of indicative) form, since it is more natural. Furthermore, some past tense verbs have also been replaced by their usage in Spain (not in America).
As for British English, I don't see any difference, but I would recommend adding it. Also, I provided a Catalan translation.
Thanks in advance,
L01D