fix: Make frontmatter.tags optional in template execution (#41) #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev#41) The execute_template function was failing when templates lacked a tags field in their YAML frontmatter, returning "frontmatter.tags must be an array (was null)". This change makes the tags field optional in ApiVaultFileResponse, aligning with standard Obsidian template practices where tags are not required. Fixes jacksteamdev#41
…jacksteamdev#41) - Test vault file response with tags array - Test vault file response without tags (optional) - Test vault file response without description (optional) - Test vault file response with empty frontmatter - Test vault file response with empty tags array - Test rejection of tags as non-array type - Test rejection of tags with non-string elements - Test required fields (content, path, stat) - Test typical Obsidian frontmatter structures - Test Templater templates without tags
✅ Deploy Preview for superb-starlight-b5acb5 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Related Issue
Fixes bug #41
🤖 Generated with Claude Code