Skip to content

Conversation

@mbelinky
Copy link

I've made changes to your code to accept multiple vaults.

@netlify
Copy link

netlify bot commented May 25, 2025

Deploy Preview for superb-starlight-b5acb5 canceled.

Name Link
🔨 Latest commit d1859f1
🔍 Latest deploy log https://app.netlify.com/projects/superb-starlight-b5acb5/deploys/6849451dd7154b0008ad85fb

Copy link
Owner

@jacksteamdev jacksteamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! Multiple vault support will be vaulable for lots of people. These changes are a step in the right direction.

I have two concerns with this PR as-is:

  1. I wasn't able to get this PR working on my computer. I'm not sure what's wrong, but I created vaults.json and configured MCP_VAULTS_CONFIG_PATH in claude_desktop_config.json.

  2. I think the installation UX for multiple vaults will probably frustrate typical non-technical users.

One of the main goals for an Obsidian plugin is to require little-to-no manual setup. Users should be able to click a button in the options page, and everything is done automatically, or at least through the UI.

This PR introduces a vaults.json file, which makes sense from a developer perspective, but we need to make it accessible to non-technical users, which means creating vaults.json automatically and guiding them through the process of adding vaults.

I know people want multiple vault support, and I really appreciate the time and effort this feature required, but I can't merge this PR without improvements to the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants