Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Webpack #25

wants to merge 10 commits into from
+133 −137

Conversation

gabrielperales
Copy link
Contributor

I have to add something to clean thebuild directory, but at least, now with webpack you don't have to run 2 commands to develop. Before you had to run gulp start and gulp server, now you just have to run npm start and that's it.

The next step will be join all .js files in just one bundle.

@gabrielperales gabrielperales force-pushed the webpack branch 2 times, most recently from 968e2fd to 1fbbdfe Compare March 19, 2017 19:37
@gabrielperales gabrielperales changed the title WIP: Webpack Webpack Mar 19, 2017
@gabrielperales
Copy link
Contributor Author

I think it is done! we have to update the README file because now the commands are:

  • npm start to run the development server.
  • npm run build to create the build folder with all the content.

@gabrielperales
Copy link
Contributor Author

I have implemented something to close #27 , you can see it here . If you are happy with that, I can join it to this pull request.

@jackfranklin
Copy link
Owner

Awesome, thank you so much! Definitely happy to have that environment variable stuff in before merging this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielperales @jackfranklin