Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments in generated code to align with Go standards #2197

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

alexandear
Copy link
Contributor

This PR updates the comments in generated files to match the standard Go regular expression:

^// Code generated .* DO NOT EDIT\.$

For more information, refer to golang/go#13560 and https://go.dev/s/generatedcode.

@jackc
Copy link
Owner

jackc commented Dec 21, 2024

I was surprised to see the changes in pgtype/integration_benchmark_test.go. It looks like a made an error years ago and had never regenerated the file. This is now fixed. Can you rebase and regenerate the files?

@jackc
Copy link
Owner

jackc commented Dec 21, 2024

pgtype/integration_benchmark_test.go still seems to have the superfluous changes.

@alexandear
Copy link
Contributor Author

pgtype/integration_benchmark_test.go still seems to have the superfluous changes.

Fixed.
It's because rake generate doesn't regenerate existing files. I need to manually remove it.

@jackc jackc merged commit e5d321f into jackc:master Dec 21, 2024
14 checks passed
@alexandear alexandear deleted the fix-generated-hdr branch December 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants