feat: Add BatchN to create a batch with an initial capacity. #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you benchmarked any significant improvements with this change? Given all that goes on in queuing the queries, sending the batch, and reading the results of all the queries, it would surprise me if removing saving the allocation was noticeable. |
|
Also, please take a look at #1878. If that proposal comes to fruition that would also allow the preallocation you are looking for. |
|
Can be solved by #1886 |
|
Closed in favor of #1886. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function BatchN which returns a batch with a pre-allocated capacity.
I ran more than once into the situation that I know beforehand how large my Batch is going to be.
As there is no way to access the slices holding the queries I've added this kind of
constructor. Maybe you find this helpful.