pgconn: normalize more connection errors #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize the error that is returned by startTLS in pgconn.connect. This makes it possible to determine if the error was a context error.
samuel
changed the title
samuel
changed the title
|
LGTM - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the error that is returned by startTLS in pgconn.connect. This makes it possible to determine if the error was a context error. Before this change the returned error for a context that is canceled or hits the deadline would be
tls error (read tcp 127.0.0.1:55914->127.0.0.1:5432: i/o timeout).This change also uses errors.As to unwrap errors in normalizeTimeoutError. This allows the function to handle the
writeErrortype that shows up asfailed to write startup message (read tcp 127.0.0.1:55914->127.0.0.1:5432: i/o timeout).