Skip to content

Commit

Permalink
Merge pull request #161 from jackalope/php8
Browse files Browse the repository at this point in the history
allow php 8
  • Loading branch information
dbu authored Oct 8, 2020
2 parents d48a2b8 + 9a25f36 commit 7381adf
Show file tree
Hide file tree
Showing 11 changed files with 108 additions and 91 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ php:
- 7.2
- 7.3
- 7.4
- nightly

sudo: false

Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Changelog
=========

1.4.1
-----

* Allow PHP 8.0

1.4
---

Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}
],
"require": {
"php": "^7.2",
"php": "^7.2 || ^8.0",
"ext-xml":"*",
"ext-dom": "*",
"ext-curl":"*",
Expand All @@ -28,9 +28,9 @@
},
"require-dev": {
"psr/log": "~1.0",
"phpcr/phpcr-api-tests": "2.1.21",
"phpcr/phpcr-api-tests": "2.1.22",
"symfony/console": "^2.3 || ^3.4 || ^4.3 || ^5.0",
"phpunit/phpunit": "^7.5"
"phpunit/phpunit": "^7.5 || ^8.0 || ^9.0"
},
"autoload": {
"psr-0": { "Jackalope\\": "src/" }
Expand Down
1 change: 0 additions & 1 deletion phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false"
syntaxCheck="true"
bootstrap="tests/bootstrap.php">
<php>
<var name="jackrabbit.uri" value="http://localhost:8080/server" />
Expand Down
5 changes: 3 additions & 2 deletions src/Jackalope/Transport/Jackrabbit/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class Client extends BaseTransport implements JackrabbitClientInterface

/**
* A list of additional HTTP headers to be sent on each request
* @var array[]string
* @var string[]
*/
protected $defaultHeaders = array();

Expand Down Expand Up @@ -199,7 +199,7 @@ class Client extends BaseTransport implements JackrabbitClientInterface
*
* This is our exception to the rule that nothing may be cached in transport.
*
* @var array of strings as returned by getRepositoryDescriptors
* @var string[] as returned by getRepositoryDescriptors
*/
protected $descriptors = null;

Expand Down Expand Up @@ -293,6 +293,7 @@ protected function getRequest($method, $uri, $addWorkspacePathToUri = true)
}
}

/** @var Request $request */
$request = $this->factory->get('Transport\\Jackrabbit\\Request', array($this, $curl, $method, $uri));

$request->setCredentials($this->credentials);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ class QueryObjectModelFactoryTest extends TestCase
*/
protected $qb;

public function setUp()
public function setUp(): void
{
$this->qf = new QueryObjectModelFactory(new Factory());
$this->qb = new QueryBuilder($this->qf);
}

public function testStatements()
public function testStatements(): void
{
//simple query, should be sql
$this->qb->from($this->qf->selector('nt:base', "nt:base"));
Expand Down
2 changes: 1 addition & 1 deletion tests/Jackalope/Test/JackrabbitTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

abstract class JackrabbitTestCase extends TestCase
{
public function setUp()
public function setUp(): void
{
parent::setUp();

Expand Down
Loading

0 comments on commit 7381adf

Please sign in to comment.