Skip to content

Commit

Permalink
Merge pull request #179 from jackalope/revert-bc-break
Browse files Browse the repository at this point in the history
revert BC break of adding return types to commands
  • Loading branch information
dbu authored Nov 14, 2023
2 parents f5459a3 + a17a3fb commit 737de4e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ Changelog
Version 1
=========

1.4.6
-----

* Revert BC break with the command return type declarations.

1.4.5
-----

Expand Down
4 changes: 2 additions & 2 deletions src/Jackalope/Tools/Console/Command/JackrabbitCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class JackrabbitCommand extends Command
*/
protected $port;

protected function configure(): void
protected function configure()
{
$this->setName('jackalope:run:jackrabbit')
->addArgument('cmd', InputArgument::REQUIRED, 'Command to execute (start | stop | status)')
Expand Down Expand Up @@ -71,7 +71,7 @@ protected function setPort($port): void
$this->port = $port;
}

protected function execute(InputInterface $input, OutputInterface $output): int
protected function execute(InputInterface $input, OutputInterface $output)
{
$cmd = $input->getArgument('cmd');

Expand Down

0 comments on commit 737de4e

Please sign in to comment.