refactor(tui): Implement Event-Editor via generic editor #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor logic This seems much better to me (despite, for now, dropping the views package). There are multiple ways to decide on this sort of thing, and many ways to get lost in the abstract what-if-edgecase sauce, but I find that the editor should allow inspecting it sufficiently to build a UI from it, rather than giving the editor all the necessities to build its own UI. Especially if we ever support something other than TUI, I think it'll be much less weird this way, imagine having to implement for each UI paradigm in every control-logic component...
Have to overhaul this soon anyways
To be quite honest, this is a chunky commit because I took a stab at this a few times with big breaks in between. I remember starting work on some part of this on the plane from South America to Europe a while ago. Basically, this fixes a bunch of outstanding design issues, finally. The following is an autogenerated commit summary: - Replaced `IsActiveAndFocussed` with `GetStatus` in `Editor` interface. - Introduced `EditorStatus` type and constants to represent editor states. - Updated `Composite` and `StringEditor` to use new `GetStatus` method. - Modified `Composite` to manage fields with a map of EditorID to Editor. - Adjusted `NewCompositeEditorPane` and `StringEditorPane` to handle new status logic. - Improved logging and error handling for editor construction and status checks.
ja-he
force-pushed
the
refactor-editor-ui-creation
branch
from
bcc1149 to
ec57d71
Compare
ja-he
changed the title
for moving at word boundaries
also fix exiting insert mode from string editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems much better to me (despite, for now, dropping the views package).
There are multiple ways to decide on this sort of thing, and many ways to get lost in the abstract what-if-edgecase sauce, but I find that the editor should allow inspecting it sufficiently to build a UI from it, rather than giving the editor all the necessities to build its own UI.
Especially if we ever support something other than TUI, I think it'll be much less weird this way, imagine having to implement for each UI paradigm in every control-logic component...