partial revert of PR #2060 (JSON parser abstraction) #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
added
the
defect
|
@stephengold do you know why the jme3-plugins JSON implementation caused this issue? |
|
No, I don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to solve the "multiple controls" portion of issue #2277. (It might solve the entire issue; I'm unsure.)
This switches JME's glTF loader back, from using the jme3-plugins-json and jme3-plugins-json-gson libraries to using Google's gson library directly.
This is only a partial revert of PR #2060 because it leaves the added jme3-plugins-json and jme3-plugins-json-gson libraries intact. Perhaps they can still be used.