fix : show short_file_name properly in Windows #35
Conversation
/// Problem:
1) Set configuration doesn't be applied in M.toggle_quick_menu()
It makes short_file_name option don't work
2) The number of slash('/') doesn't show properly in short_file_name mode.
On Windows, sometimes the file path has both '/' and '\\' as delimiter
because of neovim inherit problem.
/// Solution:
1) call get_config() function in toggle_quick_menu again.
2) On Windows, backslash of file path in buffer list is replaced by '/'
| @@ -299,6 +299,7 @@ end | |||
|
|
|||
| function M.toggle_quick_menu() | |||
| log.trace("toggle_quick_menu()") | |||
| config = buffer_manager.get_config() -- update configuration | |||
There was a problem hiding this comment.
@j-morano
That is related with what I mentioned at Problem 1.
I agree with you that line(302) don't need If normal situation, because the same code exists at line(14).
But the configuration what I set doesn't apply whenever I call toggle_quick_menu(),
although the result of require('buffer_manager').get_config() in command mode is the same with what I configured.
For debugging, I wrote some print() code at line(302) like print(config.short_file_names). The result was false before I modified this line(302)
Does it works in your environment? If it does, I think It will be changed as
if vim.fn.has('win32') then config = buffer_manager.get_config() end
I am Windows 10 / nvim 0.9.5 / loading buffer_manager at startup
There was a problem hiding this comment.
I'm warming up this discussion because I found a similar solution (see my fork) when trying to figure out why the width and height of the popup cannot be changed via the config.
I have little knowledge about lua but as far as I understand, the local config set in the top of the ui.lua file and used throughout it seems to be set before running any setup (at least when using lazy). So it always has the default values not matter what I set in the configuration. When getting the config in the function calls everything works as expected. So I think this and similar called in the other functions are very much needed. Or there is some more elegant solution one with lua experience can think of.
Also I'm using MacOS and Linux. So it is no Windows problem.
There was a problem hiding this comment.
okay. Investigated a bit more and found that it was a configuration issue on my side. I called require("buffer_manager.ui") before running the setup. So I guess it is kind of expected. Still not the behaviour I would personally expect. It would certainly be cleaner if the config would be retrieved inside the function.
1) show parents if the file name is same even though slash_count is same
6|test.lua
7|test.lua (test/)
2) show parents continuously if the parents are same
6|test.lua
7|test.lua (kkk/test/)
it is same with #56b0f2b But I missed this file update
|
Hello. What is the status of this pull request? Does it introduce new functionality or just fix this issue for Windows? |
|
@j-morano
|
/// Problem: #32
It makes short_file_name option don't work
On Windows, sometimes the file path has both '/' and '\' as delimiter
because of neovim inherit problem.
/// Solution: