Skip to content

Fix bug #18 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix bug #18 #22

wants to merge 3 commits into from

Conversation

msdemlei
Copy link
Collaborator

No description provided.

msdemlei added 3 commits April 17, 2025 13:32
@msdemlei
Replacing suitable occurrences of 1.2 with 1.3.
8396fe7
@msdemlei
Deprecating @ivo-id on Content and Creator.
3f77597 
These were erroneously introduced when nobody realised that the name
children of both already are ResourceNames.

This fixes github bug #15.
@msdemlei
Clarifying the use of inactive and deleted in Resource/@status.
c72b282 
This is supposed to fix bug #18.
tsdower
tsdower reviewed Apr 17, 2025
View reviewed changes
VOResource-v1.3.xsd
available via OAI-PMH; in the current VO, there is
probably no reason to ever do that, and deleted
records also do not show up in RegTAP searchable
registries.
Copy link
Contributor

@tsdower tsdower Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting a reason to ever do that, though it is invisible to RegTAP search users: the MAST registry continues to support OAI record persistence per https://www.openarchives.org/OAI/openarchivesprotocol.html#DeletedRecords, and when marking ivo_managed local records deleted, updates their VOResource@status to such. This makes it consistently match the OAI wrapper active/deleted status throughout the xml metadata layers and history queries.

So far I am intending to keep this behavior with the rewrite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I had originally noted this keeps the record status matching OAI wrapper status in ListRecords responses, but checking the spec it is indeed wrong to include the whole resource there, which is an issue we addressed a while back and I had forgotten. I do still like the idea of keeping it in sync even hidden from most interfaces, but it's less pressing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsdower tsdower tsdower left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msdemlei @tsdower