feat: Add configurable max_request_line_size to handle 414 errors #5394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new configuration option `max_request_line_size` that allows users to increase the HTTP request line size limit. This is particularly useful for handling very long continuation tokens that can cause 414 (URI Too Long) errors. Changes: - Add `max_request_line_size` property to Config class - Configure Kemal server to use the custom limit if specified - Document the option in config.example.yml with recommendations - Add examples in docker-compose.yml for both YAML and env var configuration The default behavior remains unchanged (8KB limit) unless explicitly configured. This provides a solution for users experiencing 414 errors without affecting existing installations.
syeopite
requested changes
Aug 23, 2025
Comment on lines
+201
to
+207
| ## | ||
| ## Accepted values: integer (size in bytes) | ||
| ## Default: 8192 (8KB, Crystal's default) | ||
| ## Recommended: 16384 (16KB) if experiencing 414 errors | ||
| ## | ||
| #max_request_line_size: 16384 | ||
|
|
There was a problem hiding this comment.
The default value should reflect the actual default value of 8192
| ## | ||
| ## Accepted values: integer (size in bytes) | ||
| ## Default: 8192 (8KB, Crystal's default) | ||
| ## Recommended: 16384 (16KB) if experiencing 414 errors |
There was a problem hiding this comment.
I don't think any default recommendations is needed here. Imo instances should decide this value according to their own requirements and needs if they decide to stray from the default 8 kilobytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a configurable
max_request_line_sizeoption to handle 414 (URI Too Long) errors that occur with very long continuation tokens in API requests.Problem
Users are experiencing 414 errors when accessing channel videos with long continuation tokens. The default HTTP request line size limit (8KB) is insufficient for some YouTube continuation tokens, which can be extremely long.
Example error:
Solution
max_request_line_sizeconfiguration option to the Config classConfiguration
Users can now configure the limit in three ways:
config.yml:docker-compose.yml:Default Behavior
Testing
Security Considerations
This change provides a flexible solution for users experiencing URL length issues without affecting existing installations.
Fixes issues related to long continuation tokens in channel video pagination.