Make caption text selectable #5332
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
added
the
need-testing
syeopite
removed
the
need-testing
|
Tested and works as expected. Though this isn't a problem right now I'm concerned that this feature could conflict with implementing freely movable captions like those seen on YouTube's official player. You can't really differentiate whether the user wants to move the captions box or select the text since it involves the same mouse movements over a very tiny space that overlaps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be really nice to be able to select and copy the caption text. The caption container has
pointer-eventsdisabled as it would otherwise eat the mouse input for the whole player area. But re-enablingpointer-eventsfor just the text container makes the text selectable without affecting the player outside of the area with text.