Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol fees endpoint #12

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

vonum
Copy link
Contributor

@vonum vonum commented Apr 30, 2024

Protocol fees endpoint has summary instead of overview.
Updated the url and added params for excluding data charts as other endpoints have.

Screenshot 2024-04-30 at 15 16 31

Copy link
Owner

@itzmestar itzmestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. please review comments then i'll approve the merge.

params = {
'excludeTotalDataChart': excludeTotalDataChart,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ep doesnt support these params. please remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, right, updated

@itzmestar itzmestar merged commit f818733 into itzmestar:main May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants