Skip to content

Commit

Permalink
Update the image version in the example file (#8)
Browse files Browse the repository at this point in the history
* Update the image version in the example file

#7

Deployed it with an older version. Works but ends up spiking in CPU usage. Easy to overlook. 

Also, for good measure/best practice, added resource request/limit.

* Bad syntax on CPU limit value
  • Loading branch information
sfxworks authored Mar 30, 2020
1 parent 3ea1149 commit be33d2c
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion docs/k8s-example-auto.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,21 @@ spec:
spec:
serviceAccountName: mc-router
containers:
- image: itzg/mc-router:1.1.1
- image: itzg/mc-router:latest
name: mc-router
args: ["--api-binding", ":8080", "--in-kube-cluster"]
ports:
- name: proxy
containerPort: 25565
- name: web
containerPort: 8080
resources:
requests:
memory: 50Mi
cpu: "100m"
limits:
memory: 100Mi
cpu: "250m"
---
apiVersion: v1
kind: Service
Expand Down

0 comments on commit be33d2c

Please sign in to comment.