🚑 replace placeholder #990
Conversation
| class="form-control url" | ||
| id="imageurl" | ||
| name="url" | ||
| placeholder="https://www.example.com/logo.png" |
There was a problem hiding this comment.
You can update just a single attribute https://odoo-source.com/?q=t-operation%3D%22attributes%22&i=nope&files=&excludeFiles=po%24%7Cpot%24&repos=13.0
Also, if possible, it's better to use configured value instead of hardcoded one (web_debranding.new_website)
There was a problem hiding this comment.
At least add a TODO about web_debranding.new_website (in 13 branch is enough)
There was a problem hiding this comment.
I made a fix for 13 too but didn't send it.
There was a problem hiding this comment.
You can update just a single attribute https://odoo-source.com/?q=t-operation%3D%22attributes%22&i=nope&files=&excludeFiles=po%24%7Cpot%24&repos=13.0
Also, if possible, it's better to use configured value instead of hardcoded one (
web_debranding.new_website)
Yes, I understand that it would be better but I decided to send quick fix without spending a lot of time
|
I approve to merge it now |
|
Approved by @trojikman
|
solves #745