Fixed issue with <kombi_request/> not using utf-8#45
Merged
Conversation
bbf1683 to
428129e
Compare
<kombi_request/> not using utf-8
428129e to
e6e9688
Compare
jekuaitk
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes (!) https://digitaliseringskataloget.dk/integration/sf1601 has trouble understanding numeric XML entities, e.g.
which leads to random errors depending on a lot of factors.
It seems that the issue stems from the
kombi_requestdocument not using theutf-8encoding. We could fix this by changingto
in
src/Service/SF1601/resources/namespaces.xslt, but it seems that we don't need that weird namespace transformation anymore, i.e. we can just use the XML document as it is.