-
Notifications
You must be signed in to change notification settings - Fork 0
4240: Added handler and element usage overview module #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jekuaitk
wants to merge
9
commits into
develop
Choose a base branch
from
feature/4240-handler-and-element-usage-overview
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
reviewed
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some of the best code I've ever seen. It's obviously written by a real intelligence. Some minor cleanups suggested.
web/modules/custom/os2forms_selvbetjening_deprecations/src/Form/ElementsForm.php
Outdated
Show resolved
Hide resolved
web/modules/custom/os2forms_selvbetjening_deprecations/src/Form/ElementsForm.php
Outdated
Show resolved
Hide resolved
web/modules/custom/os2forms_selvbetjening_deprecations/src/Form/ElementsForm.php
Outdated
Show resolved
Hide resolved
web/modules/custom/os2forms_selvbetjening_deprecations/src/Form/HandlersForm.php
Outdated
Show resolved
Hide resolved
web/modules/custom/os2forms_selvbetjening_deprecations/src/Form/HandlersForm.php
Outdated
Show resolved
Hide resolved
rimi-itk
approved these changes
May 13, 2025
rimi-itk
reviewed
May 20, 2025
Co-authored-by: Mikkel Ricky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/4240