Add 100% test coverage, fix JWKS cache bug, and modernize CI#34
Merged
Conversation
- Add 24 new tests covering all untested methods and error paths - Fix JWKS verification keys not being saved to cache (missing save() call) - Document JWT::$leeway static property limitation for multi-tenant setups - Document exp claim validation delegation to firebase/php-jwt - Add userinfo_endpoint to mock OpenID configuration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #34 +/- ##
===============================================
+ Coverage 74.41% 100.00% +25.58%
Complexity 62 62
===============================================
Files 1 1
Lines 172 172
===============================================
+ Hits 128 172 +44
+ Misses 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Fix anonymous class brace style to comply with PSR-12 - Add unreleased changelog entries for test coverage and cache fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jekuaitk
reviewed
Mar 9, 2026
|
|
||
| $item->set($keys); | ||
| $item->expiresAfter($this->cacheDuration); | ||
| $this->cacheItemPool->save($item); |
jekuaitk
approved these changes
Mar 9, 2026
- Replace monolithic pr.yaml (shivammathur/setup-php) with separate workflow files using docker compose, following the itk-dev devops template - Add phpfpm84 and phpfpm85 services using compose extends - Run unit tests across PHP 8.3, 8.4, and 8.5 - Fix implicit nullable parameters deprecated in PHP 8.4 - Update actions/checkout to v5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
turegjorup
changed the title
Add `user: ${COMPOSE_USER:-deploy}` to phpfpm service, matching the
itk-dev devops template pattern. CI sets COMPOSE_USER=runner so
composer can write to the volume-mounted workspace.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Consolidate separate phpcs, phpstan, and phpunit workflows into a single php.yaml workflow. Update composer.yaml with prefer matrix and inline user flag. Remove COMPOSE_USER env var in favor of --user flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jekuaitk
approved these changes
Mar 10, 2026
Collaborator
jekuaitk
left a comment
jekuaitk
left a comment
There was a problem hiding this comment.
Looks good! Two comments/statements but approved.
| $glue = parse_url($url, PHP_URL_QUERY) === null ? '?' : '&'; | ||
| $url .= $glue . $this->buildQueryString($params); | ||
| $glue = null === parse_url($url, PHP_URL_QUERY) ? '?' : '&'; | ||
| $url .= $glue.$this->buildQueryString($params); |
Collaborator
There was a problem hiding this comment.
This must be a new rule. I've always been bugged by our coding standards to keep these spaces 👀
| ```shell | ||
| docker compose exec phpfpm composer install | ||
| docker compose exec phpfpm ./vendor/bin/phpunit | ||
| task pr:actions |
| cmds: | ||
| - "{{.PHP}} vendor/bin/php-cs-fixer fix" | ||
|
|
||
| lint:composer: |
Collaborator
There was a problem hiding this comment.
Im not sure i would classify all the steps in this task as linting but i suppose it works.
Use per-combination Docker services (PHP version × dependency set) with isolated named volumes to prevent vendor cross-contamination between matrix runs. Align test:matrix pattern with openid-connect-bundle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace php.yaml (had duplicate composer content) with proper PHP workflow including coding-standards, phpstan, and unit-tests jobs - Update service names to match docker-compose.yml (phpfpm84-stable, phpfpm85-stable instead of phpfpm84, phpfpm85) - Add docker network create frontend steps to all jobs - Remove pr.yaml (content moved to php.yaml) - Remove unnecessary matrix from composer-validate job - Fix Taskfile.yml prettier formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restore php.yaml with correct service names for CI matrix. Simplify docker-compose base service to match itkdev template 3.2.1 and add simple phpfpm84/phpfpm85 services. Matrix services now extend their version-specific parent instead of repeating image overrides. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add user, networks, and extra_hosts to phpfpm base service to fix CI permission errors (composer.lock write denied). Matches the pattern from openid-connect-bundle PR #27. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add composer:check task (validate, normalize, audit). Rename analyze to analyze:php for clarity. Add composer:check to pr:actions. Simplify test:matrix formatting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Correct inconsistent 2-space indentation in composer:check and test:matrix tasks to match the 4-space convention used throughout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jekuaitk
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
6996
Summary
save()call)shivammathur/setup-phpto Docker Composeextendstask setup,task test,task test:matrix,task pr:actions)composer.jsonwithergebnis/composer-normalizephpcs.xml.distwith PHP-CS-Fixer configuration via TaskfileTest plan
🤖 Generated with Claude Code