Skip to content

Job steps cleanup #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Job steps cleanup #113

wants to merge 2 commits into from

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Jul 2, 2025

  • Puts network creating in separate step to make it more clear what actually goes wrong in case of failure
  • Added blank lines between steps

@rimi-itk rimi-itk force-pushed the feature/network-create-steps branch from 9d9ce26 to 6cca8e7 Compare July 2, 2025 10:28
@rimi-itk rimi-itk marked this pull request as ready for review July 2, 2025 10:29
@rimi-itk rimi-itk requested review from tuj, martinyde and turegjorup July 2, 2025 10:29
@turegjorup
Copy link
Contributor

Puts network creating in separate step to make it more clear what actually goes wrong in case of failure

We could add name if we need prettier output when the workflow is run:

jobs:
  composer-validate:
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
    steps:
      - uses: actions/checkout@v4

      - name: Create docker network
        run: |
           docker network create frontend

      - name: Composer validate
        run: |
           docker compose run --rm phpfpm composer validate --strict

@rimi-itk rimi-itk requested review from turegjorup, martinyde and tuj July 3, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants