Notifications for technicians in tickets #835
Conversation
All emails go through the mail queue, using the addToMailQueue() function.
|
Test these changes at: https://ticketnotifications835.pr-review.itflow.org |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $subject = $email['subject']; | ||
| $body = $email['body']; | ||
|
|
||
| mysqli_query($mysqli, "INSERT INTO email_queue SET email_recipient = '$recipient', email_recipient_name = '$recipient_name', email_from = '$config_invoice_from_email', email_from_name = '$config_invoice_from_name', email_subject = '$subject', email_content = '$body'"); |
Check failure
Code scanning / SonarCloud
Database queries should not be vulnerable to injection attacks
Forgot to add in the sanitations.
|
|
This looks fantastic and was much needed to be done. I like new function. @o-psi Did you test all or some the mail Functionality with this update by chance? |
|
I tested Invoice, Quotes, reset password, and generate password. |
|
Merging in we'll test from here but everything looks good |
This pull request refactors the email functionality in the codebase to use the newly created addToMailQueue function. This function centralizes the process of adding emails to the email queue, improving code organization and reducing code duplication.
This was needed to be done IMO before 1.0.
This also fixed the notifications for technicians as mentioned here: #563