Add warning when a user implicitly converts an IDS between major versions on put() #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions on put() And fix an example in the multi-DD documentation.
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
Collaborator
|
Thanks for this, I feel that this PR is enough for the time being (plus it kind of the same when reading the data). |
olivhoenen
approved these changes
Oct 30, 2025
maarten-ic
deleted the
feature/warning-for-implicit-conversion-3to4-on-put
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix an example in the multi-DD documentation.
@olivhoenen implicit data conversion on put() is perhaps too confusing to users. We could also choose to remove the feature altogether and raise an error when trying to
putorput_slicean IDS with a different DD version than the DBEntry.See also the discussion with @DavidPCoster in the IMASusers Slack.